Re: [PATCH] Normalize svn:ignore pattern matching

On 6/16/06, Osku Salerma <osku@iki.fi> wrote:
> Currently, knowledge that svn:ignore only supports glob patterns is
> duplicated in four functions: send_unversioned_item, add_dir_recursive,
> import_dir, and import. This is bad for modularity, as you would need to
> modify all four places if you e.g. added support for reg-exps in
> svn:ignore patterns.
>
> The attached patch modifies the four functions to use a new function,
> svn_cstring_match_ignore_list, that currently only forwards to
> svn_cstring_match_glob_list, but can in the future be modified to do more.
>
> I'm not sure if svn_string.c is the correct place for the new function;
> feel free to suggest a better place.
svn_ctring.c is wrong place for this functions. It should be private
libsvn_wc function with name like svn_wc__match_ignore_list()

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org