[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Normalize svn:ignore pattern matching

From: Osku Salerma <osku_at_iki.fi>
Date: 2006-06-16 16:33:53 CEST

Currently, knowledge that svn:ignore only supports glob patterns is
duplicated in four functions: send_unversioned_item, add_dir_recursive,
import_dir, and import. This is bad for modularity, as you would need to
modify all four places if you e.g. added support for reg-exps in
svn:ignore patterns.

The attached patch modifies the four functions to use a new function,
svn_cstring_match_ignore_list, that currently only forwards to
svn_cstring_match_glob_list, but can in the future be modified to do more.

I'm not sure if svn_string.c is the correct place for the new function;
feel free to suggest a better place.

Make all svn:ignore pattern matching go through a single function to make
future enhancements easier.

* subversion/include/svn_string.h
  (svn_cstring_match_ignore_list): New function declaration.

* subversion/libsvn_subr/svn_string.c
  (svn_cstring_match_ignore_list): New function.

* subversion/libsvn_wc/status.c (send_unversioned_item)
  subversion/libsvn_client/add.c (add_dir_recursive)
  subversion/libsvn_client/commit.c (import_dir, import):

  Use svn_cstring_match_ignore_list instead of svn_cstring_match_blob_list.

Osku Salerma - osku_at_iki.fi - http://www.oskusoft.com/osku/

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Jun 16 16:44:18 2006

This is an archived mail posted to the Subversion Dev mailing list.