[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn2rss.py: Improve error handling and add --max-itemsoption

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-06-16 18:13:26 CEST

Bhuvaneswaran wrote:
>>Here, you should validate the input a bit:
>>
>> try:
>> max_items = arg
>> except ValueError, msg:
>> usage_and_exit("Invalid value '%s' for --max-items." % (arg))
>> if max_items < 1:
>> usage_and_exit("Value for --max-items must be a positive integer.")
>
> Yeah, i did the change except a trivial correction. The correction is as
> follows:
>
> max_items = int(arg)
>
> IMO, it serves the purpose better.

Ahem. Yes, of course. (That's what I get for freetyping into the mail
instead of actually tweaking the script and testing.)

> [[[
> Add --max-items option
>
> Patch by: Bhuvaneswaran <bhuvan@collab.net>
> Suggested by: cmpilato
>
> * svn2rss.py
> (__init__): Add --max-items option
> ]]]

Looks good. Committed in r20146.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Fri Jun 16 18:14:12 2006

This is an archived mail posted to the Subversion Dev mailing list.