[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn2rss.py: Improve error handling and add--max-itemsoption

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2006-06-16 11:44:37 CEST

Hello,

I've implemented the proposed changes and attached the patch. Please see
my comment against each remarks.

> > Index: svn2rss.py
>
> Note for the future -- always generate your patches from the top of the
> Subversion tree.
>

ok.

> Now, this is odd. Why not go ahead and set max_items = 20?
>

Yes, i did.

> Here, you should validate the input a bit:
>
> try:
> max_items = arg
> except ValueError, msg:
> usage_and_exit("Invalid value '%s' for --max-items." % (arg))
> if max_items < 1:
> usage_and_exit("Value for --max-items must be a positive integer.")
>

Yeah, i did the change except a trivial correction. The correction is as
follows:

       max_items = int(arg)

IMO, it serves the purpose better.

>
> self.max_items = max_items
>

Ok, i did this. Here is the log message:

[[[
Add --max-items option

Patch by: Bhuvaneswaran <bhuvan@collab.net>
Suggested by: cmpilato

* svn2rss.py
  (__init__): Add --max-items option
]]]

-- 
Regards,
Bhuvaneswaran

Received on Fri Jun 16 11:45:28 2006

This is an archived mail posted to the Subversion Dev mailing list.