[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20091 - branches/merge-tracking/subversion/libsvn_fs_fs

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2006-06-14 16:28:59 CEST

Garrett Rooney wrote:
> On 6/13/06, dberlin@tigris.org <dberlin@tigris.org> wrote:
>
>> st = svn_string_createf(pool,
>> - "delete from mergeinfo_uuid where revision = %"
>> + "delete from mergeinfo_changed where revision = %"
>> + SVN_REVNUM_T_FMT ";", new_rev);
>> + SVN_ERR(fs_sqlite_exec(ftd->mtd, st->data, NULL, NULL));
>> + st = svn_string_createf(pool,
>> + "delete from mergeinfo where revision = %"
>> SVN_REVNUM_T_FMT ";", new_rev);
>> SVN_ERR(fs_sqlite_exec(ftd->mtd, st->data, NULL, NULL));
>
> Any particular reason this stuff uses svn_string_t?

No.
I was trying to get something quickly for dlr to be able to test with,
and this was the first way to do that that popped into my head :)

I've fixed it now.

 You don't seem to
> actually use the length, so you might as well just use apr_psprintf
> and generate char *s.
>
> -garrett
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 14 16:34:16 2006

This is an archived mail posted to the Subversion Dev mailing list.