[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20091 - branches/merge-tracking/subversion/libsvn_fs_fs

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-06-14 15:53:47 CEST

On 6/13/06, dberlin@tigris.org <dberlin@tigris.org> wrote:

> st = svn_string_createf(pool,
> - "delete from mergeinfo_uuid where revision = %"
> + "delete from mergeinfo_changed where revision = %"
> + SVN_REVNUM_T_FMT ";", new_rev);
> + SVN_ERR(fs_sqlite_exec(ftd->mtd, st->data, NULL, NULL));
> + st = svn_string_createf(pool,
> + "delete from mergeinfo where revision = %"
> SVN_REVNUM_T_FMT ";", new_rev);
> SVN_ERR(fs_sqlite_exec(ftd->mtd, st->data, NULL, NULL));

Any particular reason this stuff uses svn_string_t? You don't seem to
actually use the length, so you might as well just use apr_psprintf
and generate char *s.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 14 15:55:01 2006

This is an archived mail posted to the Subversion Dev mailing list.