On Thu, 08 Jun 2006, Greg Hudson wrote:
> On Thu, 2006-06-08 at 18:52 -0700, dlr@tigris.org wrote:
> > * subversion/svnserve/serve.c
> > (write_proplist): Gate declaration of some local stack variables in
> > the NULL check which protects this function body.
>
> When I wrote svnserve and ra_svn, I believed (as I do now) that it is
> distracting and of little value to have variable declarations within
> blocks. At the time, style decisions like that were made at a file
> level.
>
> I know we recently made a decision to normalize space-before-paren, and
> following the same logic we should perhaps use block-internal variable
> declarations in ra_svn and svnserve for consistency with the rest of the
> code base. But it certainly seems wrong to make this piecemeal change
> to one tiny bit of the code, rendering it inconsistent with most of the
> rest of ra_svn and svnserve.
The use of this style in serve.c was not readily apparent. In the
first 500 or so LOCs of serve.c, I see only a couple variable
declarations which are not just-in-time. In any case, I was not
intending to change the coding style of the file, so I've reverted the
commit in r20073 until such time that a more comprehensive change is
made.
- Dan
- application/pgp-signature attachment: stored
Received on Tue Jun 13 03:27:46 2006