[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20020 - trunk/subversion/svnserve

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2006-06-09 04:04:40 CEST

On Thu, 2006-06-08 at 18:52 -0700, dlr@tigris.org wrote:
> * subversion/svnserve/serve.c
> (write_proplist): Gate declaration of some local stack variables in
> the NULL check which protects this function body.

When I wrote svnserve and ra_svn, I believed (as I do now) that it is
distracting and of little value to have variable declarations within
blocks. At the time, style decisions like that were made at a file
level.

I know we recently made a decision to normalize space-before-paren, and
following the same logic we should perhaps use block-internal variable
declarations in ra_svn and svnserve for consistency with the rest of the
code base. But it certainly seems wrong to make this piecemeal change
to one tiny bit of the code, rendering it inconsistent with most of the
rest of ra_svn and svnserve.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 9 04:05:17 2006

This is an archived mail posted to the Subversion Dev mailing list.