[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn2rss.py patch

From: Bhuvaneswaran <bhuvan_at_ubuntu.com>
Date: 2006-06-09 14:57:31 CEST

> * The script should call sys.exit(1) at the end of "except
> ImportError" block
>
> * Add a --max-items option.
>
> * --revision could take a range, like the 'svn' client does.
>
> * Lose --url, and add --url-template, which is a URL with replaceable
> fields, such as:
>
> http://svn.collab.net/viewvc/{repository}/?rev={revision}
>
> Dan Rall probably thought he was being helpful when he removed the
> mentioned of "viewcvs" from the --url description, but the new
> text implies a generality of the URL format which frankly isn't there.
>
> * Come up with decent default values for options for which
> it makes sense to do so:
>
> --svn-path could default to nothing, meaning "look in $PATH"
> --rss-file could default to os.path.basename(self.repos_path) \
> + ".rss"
> --revision could default to the youngest revision in the repos
>
> Alternatively, the script should validate input before trying to act
> on it. Today you get cryptic errors as the script tries to use
> uninitialized variables and the likes.
>
> * Lose --repos-path, and make it a command-line argument, not an option.
> In conjunction with the other changes mentioned here, that would mean
> that running this script could be as simple as:
>
> svn2rss.py \
> --url http://svn.collab.net/viewvc/{repository}/?rev={revision} \
> /path/to/repository

I guess I have addressed all the issues/enhancements suggested by
cmpilato. I have also fine tuned the error handling mechanism.
Herewith, I've attached the patch. Please verify and apply. Thank you!

-- 
Regards,
Bhuvaneswaran
www.symonds.net/~bhuvan/
GPG: 0x7A13E5B0


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Jun 9 14:58:11 2006

This is an archived mail posted to the Subversion Dev mailing list.