[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Version 1.4.0: svn st errors out

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-06-06 17:23:59 CEST

Garrett Rooney wrote:
>> The 1.4.0 version explicitly does NOT repair inconsistent line
>> endings, but
>> (unfortunately) also doesn't gracefully handle that error condition.
>
>
> Well, I guess the question is, what should it do in that error
> condition? I assume its trying to translate so that it can do a
> comparison with the text base and determine if the file has changed or
> not, if we can't translate due to busted eol style do we just assume
> that the file has been modified?

Correct.

> (On a side note, where in the code is this? The only translation code
> that looks promising is in libsvn_wc/diff.c, does libsvn_wc/status.c
> end up calling in there? I can't actually seem to reproduce the
> actual error on a unix machine, so I can't just look at the
> maintainer-mode error to see where it came from...)

I have not reproduced this problem either -- am just reading code. So, what
previously I writ, and what followeth from my hand, might be, as they say in
the Greek, "hogwash".

But in status.c there lives a call to svn_wc_text_modified_p, which calls
svn_wc__text_modified_internal_p, which calls compare_and_verify, which does
translation-y things (and got heavily reworked between 1.3.2 and 1.4.0).

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Tue Jun 6 17:31:19 2006

This is an archived mail posted to the Subversion Dev mailing list.