[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Version 1.4.0: svn st errors out

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-06-06 17:19:27 CEST

On 6/5/06, C. Michael Pilato <cmpilato@collab.net> wrote:
> If I'm reading the code correctly, the 1.3.2 version forces repair of
> inconsistent line endings, which is good in that it doesn't make this error
> show up, but (I'm supposing) bad in that it might keep newline-only changes
> from showing up as modifications.
>
> The 1.4.0 version explicitly does NOT repair inconsistent line endings, but
> (unfortunately) also doesn't gracefully handle that error condition.

Well, I guess the question is, what should it do in that error
condition? I assume its trying to translate so that it can do a
comparison with the text base and determine if the file has changed or
not, if we can't translate due to busted eol style do we just assume
that the file has been modified?

(On a side note, where in the code is this? The only translation code
that looks promising is in libsvn_wc/diff.c, does libsvn_wc/status.c
end up calling in there? I can't actually seem to reproduce the
actual error on a unix machine, so I can't just look at the
maintainer-mode error to see where it came from...)

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 6 17:20:43 2006

This is an archived mail posted to the Subversion Dev mailing list.