Re: Using a non-zero timeout in svn_ra_svn__input_waiting()

On Tue, Jun 06, 2006 at 01:47:48PM +0200, Ph. Marek wrote:
> There you'll find this part (around line 126):
> svn_boolean_t svn_ra_svn__input_waiting(svn_ra_svn_conn_t *conn,
> apr_pool_t *pool)

> HERE> return ((apr_poll(&pfd, 1, &n, 0) == APR_SUCCESS) && n);
>
> May I suggest using a non-zero timeout (eg. 1000us) or possibly -1 (infinite)?
> I only ask because it's a bit inconvinient currently:
> $ top
> PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
> 4038 flip 18 0 62144 44m 3196 R 53.4 8.8 6:54.89 svnserve
>

That function is working as designed: if returns immediately, signalling
whether there is any input waiting on the connection. We use it during
a pipelined editor drive to determine if there's an error return we need
to deal with, so a non-zero timeout would be inappropriate.

That said, if your svnserve isn't actually handling a connection, could
you try to find out what it _is_ doing? It shouldn't be busywaiting
like that, and it _really_ shouldn't be using that much memory.

$ top
  PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
17248 svn 9 0 1308 1308 988 S 0.0 0.3 0:00.01 svnserve

(1.3.2; running for almost a week now).

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 6 14:58:10 2006