[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Agggh! 64-bit bug still present in 1.3.2 (PATCH already in issue tracker)

From: David James <djames_at_collab.net>
Date: 2006-06-05 21:20:50 CEST

On 6/5/06, Toby Johnson <toby@etjohnson.us> wrote:
> David James wrote:
> > On 6/5/06, Nico Kadel-Garcia <nkadel@comcast.net> wrote:
> >> > I've also unsuccessfully sent patches for this issue to David Summers
> >> > (whom I'm also copying in) but I didn't realize the .spec sources were
> >> > in the "official" repository. You may have better luck submitting a
> >> > new patch directly to this list with [PATCH] in the subject (making
> >> > sure it still applies cleanly to the latest trunk), although I don't
> >> > know if anyone else would be willing to apply the patches.
> >>
> >> Hmm. Maybe David's swamped right now? His work on this up to now has
> >> been
> >> very helpful, providing RPM's and SRPM's for i386 architecture. My
> >> patch is
> >> on
> >>
> >> > If no one is still willing to apply your patch then I will offer to
> >> > host the corrected SRPMs and RHEL-4 64 bit binaries myself, but of
> >> > course getting this bug fixed in the trunk would be preferable.
> >>
> >> My latest patch is at:
> >>
> >>
> >> http://subversion.tigris.org/nonav/issues/showattachment.cgi/558/x86_64.patch
> >>
> >
> > Hi Nico,
> >
> > I'm not terribly familiar with the syntax for RPM spec files, but I
> > looked at your patch and it seems quite reasonable and useful.
> > Assuming that your patch is required to compile the RHEL-4 binaries on
> > x86_64, and that it does not cause any problems on other
> > architectures, it seems like it is definitely a good idea to commit it
> > and backport to 1.3.x.
> >
> > Cheers,
> >
> > David
> >
> > Toby, can you test Nico's patch and confirm that it
> >
> I assume you meant to finish this sentence with "confirm that it
> compiles", so yes, I'll confirm it tonight.

Thanks! I just want to make sure the fix is good before we release it :)

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 5 21:21:14 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.