[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19915 - trunk

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2006-06-02 23:56:55 CEST

> Log:
> Require APR 0.9.7, since it detects error while writing to buffered files.
>
> Older APR versions don't. It seems like the only way we can assure correct
> file writes in FSFS repositories.
>
> * configure.in (APR_VER_REGEXES,
> APU_VER_REGEXES): Increase minimum version to 0.9.7.

I have proposed this change for backport to 1.4.x, but shouldn't it be
backported to all branches that have FSFS as their default repository,
or even to all branches which include FSFS period? I mean, it may
(rarely) cause dataloss or at least data integrity problems...

bye,

Erik.

>
> Modified: trunk/configure.in
> URL: http://svn.collab.net/viewvc/svn/trunk/configure.in?pathrev=19915&r1=19914&r2=19915
> ==============================================================================
> --- trunk/configure.in (original)
> +++ trunk/configure.in Fri Jun 2 14:46:59 2006
> @@ -55,13 +55,14 @@
>
> dnl verify apr version and set apr flags
> dnl These regular expressions should not contain "\(" and "\)".
> -dnl The specific reasons we require APR 0.9.5-final are:
> -dnl - APR_LARGEFILE added
> -dnl - APR_GSETID added
> -dnl - bug in apr_temp_dir_get() fixed
> +dnl The specific reason we require APR 0.9.7 is:
> +dnl It contains fixes to its file writing routines
> +dnl now generating errors instead of silently ignoring
> +dnl them. Only .7 and later can guarantee repository
> +dnl integrety with FSFS.
>
> -APR_VER_REGEXES=["0\.9\.[5-9] 0\.9\.1[0-9] 1\."]
> -APU_VER_REGEXES=["0\.9\.[5-9] 0\.9\.1[0-9] 1\."]
> +APR_VER_REGEXES=["0\.9\.[7-9] 0\.9\.1[0-9] 1\."]
> +APU_VER_REGEXES=["0\.9\.[7-9] 0\.9\.1[0-9] 1\."]
>
> SVN_LIB_APR($APR_VER_REGEXES)
> SVN_LIB_APRUTIL($APU_VER_REGEXES)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 2 23:57:29 2006

This is an archived mail posted to the Subversion Dev mailing list.