[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19803 - in trunk/subversion/bindings/java/javahl: native src/org/tigris/subversion/javahl

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-05-25 20:15:59 CEST

On Wed, 24 May 2006, Daniel Rall wrote:

> On Wed, 24 May 2006, Mark Phippard wrote:
>
> > Daniel Rall <dlr@collab.net> wrote on 05/24/2006 04:19:25 PM:
> >
> > > On a related note, here at CollabNet we were wondering if the
> > > SVNClientInterface.username() and password() Java methods should even
> > > accept null input, or should instead throw IllegalArgumentException
> > > [1]. Setting a null username seems like a pretty bogus operation to
> > > me, setting a null password perhaps less so. Thoughts?
> >
> > In Subclipse we use the callback interface, PromptUserPassword, and I
> > remember wondering if I should set username/password to null to be clear I
> > wanted the callback. I guess I do not do that since the JVM does not
> > crash. That being said, receiving an exception would have likely answered
> > my question the first time I ran it.
>
> Mark, David, thanks for your feedback. How about this patch?
>
> [[[
> Disallow use of null arguments to the client credential portion of the
> JavaHL API (which previous to r19803 resulted in a segfault and thus a
> hard JVM crash), instead throwing an IllegalArgumentException.
...

I've committed this patch as r19813, and nominated it for backport to
1.4.x alongside r19803 (fix for the segfault triggering the JVM crash).

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Thu May 25 20:16:43 2006

This is an archived mail posted to the Subversion Dev mailing list.