[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19803 - in trunk/subversion/bindings/java/javahl: native src/org/tigris/subversion/javahl

From: David James <djames_at_collab.net>
Date: 2006-05-24 22:26:32 CEST

On 5/24/06, Daniel Rall <dlr@collab.net> wrote:
> On a related note, here at CollabNet we were wondering if the
> SVNClientInterface.username() and password() Java methods should even
> accept null input, or should instead throw IllegalArgumentException
> [1]. Setting a null username seems like a pretty bogus operation to
> me, setting a null password perhaps less so. Thoughts?

I think we should throw an IllegalArgumentException. If somebody wants
to set an empty password or an empty username, they can do so by
passing the empty string. There's no need to also allow users to pass
in null for this purpose.

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 24 22:27:23 2006

This is an archived mail posted to the Subversion Dev mailing list.