[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [SVNMERGE][PATCH] svnmerge rollback

From: Giovanni Bajo <rasky_at_develer.com>
Date: 2006-05-19 15:12:38 CEST

Madan U Sreenivasan wrote:

>>>> + # make sure theres some revision to
>> rollback
>>>> + if len(revs) == 0:
>>>> + warn("Nothing to rollback in
>> revision range r%s" %
>> opts["revision"])
>>>> + return
>> I'd rather this be a report for now, and
>> then have a separate commit pass
>> which introduces warn() and uses it
>> consistenly across the program (once the
>> semantic is clear).
>
> I will revert this warn() function and use report() for now.... but I
> would like to know what you mean by 'semantic', so that I could
> provide that patch sooner, than later.

We should first agree on a strict definition of warn(), so that it becomes
obvious when to use warn() rather than report(). Once we have this
agreement, the mechanical patch to change some of the report() calls into
warn() is obviously ok.

-- 
Giovanni Bajo
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 19 15:13:16 2006

This is an archived mail posted to the Subversion Dev mailing list.