[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [SVNMERGE][PATCH] svnmerge rollback

From: Giovanni Bajo <rasky_at_develer.com>
Date: 2006-05-19 15:11:33 CEST

Madan U Sreenivasan wrote:

>>>> + oldest_src_rev =
>> get_created_rev(opts["head-url"])
>>>> + src_pre_exist_range =
>> RevisionSet("1-%d" % oldest_src_rev)
>> Is this test really necessary? Doesn't the
>> merge command just fail if you
>> try reverting a revision at which the URL
>> did not exist?
> yes, it does... but wouldnt it make sense to say the rollback command
> failed instead of letting the user see a merge failure? Much more
> cleaner, I think.

What happens, exactly, if you remove that test? What's the actual output?

The point is that the check does not come for free. It is expensive if you
use a remote repository. Since the actual "svn merge" command is already
going to fail, I don't think we should care. Do you have a legitimate usage
case for this?

Giovanni Bajo
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 19 15:12:07 2006

This is an archived mail posted to the Subversion Dev mailing list.