[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][SVNMERGE] Refactoring svnmerge.py in anticipation of 'svnmerge rollback'

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-05-10 12:47:00 CEST

On Wed, 10 May 2006 15:29:29 +0530, David Anderson
<david.anderson@calixo.net> wrote:

> * Madan U Sreenivasan <madan@collab.net> [2006-05-10 14:22:08]:
>> Index: contrib/client-side/svnmerge.py
>> ===================================================================
>> --- contrib/client-side/svnmerge.py (revision 19600)
>> +++ contrib/client-side/svnmerge.py (working copy)
>> @@ -955,6 +955,14 @@
>> else:
>> assert False, "unhandled display style: %s" % display_style
>>
>> +def write_commit_log(commit_file, msg):
>> + "Write the commit message into the commit_file provided"
>> +
>> + f = open(opts["commit-file"], "w")
>
> Why are you passing a commit_file argument, and then opening
> opts["commit-file"] ? Shouldn't this be:
>
> f = open(commit_file, "w")
>
> ?

/me grins sheepishly... yes, and worse still, since ops is global, it
doesnt even error out!

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 10 12:16:21 2006

This is an archived mail posted to the Subversion Dev mailing list.