[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][SVNMERGE] Refactoring svnmerge.py in anticipation of 'svnmerge rollback'

From: David Anderson <david.anderson_at_calixo.net>
Date: 2006-05-10 11:59:29 CEST

* Madan U Sreenivasan <madan@collab.net> [2006-05-10 14:22:08]:
> Index: contrib/client-side/svnmerge.py
> ===================================================================
> --- contrib/client-side/svnmerge.py (revision 19600)
> +++ contrib/client-side/svnmerge.py (working copy)
> @@ -955,6 +955,14 @@
> else:
> assert False, "unhandled display style: %s" % display_style
>
> +def write_commit_log(commit_file, msg):
> + "Write the commit message into the commit_file provided"
> +
> + f = open(opts["commit-file"], "w")

Why are you passing a commit_file argument, and then opening
opts["commit-file"] ? Shouldn't this be:

f = open(commit_file, "w")

?

- Dave.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 10 11:59:13 2006

This is an archived mail posted to the Subversion Dev mailing list.