[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] show log message before changed paths in mailer.py

From: David James <djames_at_collab.net>
Date: 2006-05-03 18:20:53 CEST

On 5/3/06, Mathias Weinert <mathias.weinert@gfa-net.de> wrote:
> I first posted this patch at the end of march to the dev list
> (http://svn.haxx.se/dev/archive-2006-03/1225.shtml). After some
> discussion and improvements I posted a second version of the patch
> some days later (http://svn.haxx.se/dev/archive-2006-03/1268.shtml).
>
> But since that time nothing more happened. My feeling was that the patch
> was accepted and that nobody had objections against committing it. So I
> kindly ask you to commit this patch to mailer.py.

Thanks very much for following up on this! I appreciate your kind
attention to detail and your summary of the discussion. I committed
your patch in r19502.

Cheers,

David

>
> Thank you very much!
>
> Mathias
>
> [[[
> * tools/hook-scripts/mailer/mailer.py
> Show log message before changed paths (instead of after)
> ]]]
>
> --- tools/hook-scripts/mailer/mailer.py.orig 2005-12-15 01:57:49.000000000 +0100
> +++ tools/hook-scripts/mailer/mailer.py 2006-03-29 10:05:51.073150700 +0200
> @@ -882,8 +882,8 @@
>
> w = self.output.write
>
> - w('Author: %s\nDate: %s\nNew Revision: %s\n\n'
> - % (data.author, data.date, data.rev))
> + w('Author: %s\nDate: %s\nNew Revision: %s\n\nLog:\n%s\n\n'
> + % (data.author, data.date, data.rev, data.log))
>
> # print summary sections
> self._render_list('Added', data.added_data)
> @@ -900,8 +900,6 @@
> else:
> w('and changes in other areas\n')
>
> - w('\nLog:\n%s\n' % data.log)
> -
> self._render_diffs(data.diffs)
> if data.other_diffs:
> w('\nDiffs of changes in other areas also in this revision:\n')
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 3 18:24:34 2006

This is an archived mail posted to the Subversion Dev mailing list.