[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] show log message before changed paths in mailer.py

From: Mathias Weinert <mathias.weinert_at_gfa-net.de>
Date: 2006-03-30 08:55:52 CEST

C. Michael Pilato wrote:
> Julian Foad wrote:
> > C. Michael Pilato wrote:
> >
> >> Julian Foad wrote:
> >>
> >>>>> + w('Author: %s\nDate: %s\nNew Revision: %s\n\nLog: %s\n\n'
> >>>>> + % (data.author, data.date, data.rev, data.log))
> >>>
> >>> [...]
> >>>
> >>>>> - w('\nLog:\n%s\n' % data.log)
> >>>
> >>>
> >>> ... it looks to me like it wrongly omits a newline after "Log:".
> >>
> >>
> >> I'd call that a bugfix. A multi-line log message really should begin
> >> on its
> >> own dedicated line.
> >
> >
> > Er... what? I'd call that the introduction of a bug, for the very same
> > reason. Note that the lines added are shown first, and the lines
> > deleted are shown afterwards.
>
> Ahem. No, really, I *can* read diff format, I swear!
>
> /me returns to his cave.

Thanks for reviewing my patch and finding the newly introduced bug!
Could you be so kind to commit the patch (I enclosed a patched version
in this mail)?

Mathias

P.S.: I still dont't give up hoping that someone will commit my other
patch to mailer.py...
(Original post: http://svn.haxx.se/dev/archive-2006-02/0293.shtml,
several follow-ups exist)

[[[
* tools/hook-scripts/mailer/mailer.py
  Show log message before changed paths (instead of after)
]]]

--- tools/hook-scripts/mailer/mailer.py.orig 2005-12-15 01:57:49.000000000 +0100
+++ tools/hook-scripts/mailer/mailer.py 2006-03-29 10:05:51.073150700 +0200
@@ -882,8 +882,8 @@
 
     w = self.output.write
 
- w('Author: %s\nDate: %s\nNew Revision: %s\n\n'
- % (data.author, data.date, data.rev))
+ w('Author: %s\nDate: %s\nNew Revision: %s\n\nLog:\n%s\n\n'
+ % (data.author, data.date, data.rev, data.log))
 
     # print summary sections
     self._render_list('Added', data.added_data)
@@ -900,8 +900,6 @@
       else:
         w('and changes in other areas\n')
 
- w('\nLog:\n%s\n' % data.log)
-
     self._render_diffs(data.diffs)
     if data.other_diffs:
       w('\nDiffs of changes in other areas also in this revision:\n')

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 30 08:56:12 2006

This is an archived mail posted to the Subversion Dev mailing list.