[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] use WIN32_RETRY_LOOP also for cygwin

From: Mathias Weinert <mathias.weinert_at_gfa-net.de>
Date: 2006-05-03 16:57:30 CEST

Hi there

In libsvn_subr/io.c there is macro called WIN32_RETRY_LOOP used to do
several retries of some file commands like rename. As the problem which
this macro shall solve - or at least soothe - also exists under cygwin
I would like this macro to also be used if under cygwin.

The following patch is just quick and dirty (indeed it's very dirty)
but it shows what I mean (and it works and helps).

Are there any objections against such a change (in principal)?

Mathias

--- subversion/libsvn_subr/io.c.orig 2005-11-17 00:05:43.000000000 +0100
+++ subversion/libsvn_subr/io.c 2006-05-03 16:31:00.062477500 +0200
@@ -71,7 +71,12 @@
   goes a long way towards minimizing it. It is not an infinite
   loop because there might really be an error.
 */
-#ifdef WIN32
+#ifdef CYGWIN
+#define ERROR_ACCESS_DENIED 5L
+#define ERROR_SHARING_VIOLATION 32L
+#endif
+
+#if defined(WIN32) | defined(CYGWIN)
 #define WIN32_RETRY_LOOP(err, expr) \
   do \
     { \

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 3 16:58:00 2006

This is an archived mail posted to the Subversion Dev mailing list.