[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix Issue #1997

From: Paul Burba <paulb_at_softlanding.com>
Date: 2006-04-21 19:10:46 CEST

Julian Foad <julianfoad@btopenworld.com> wrote on 04/20/2006 04:14:16 PM:

> Paul Burba wrote:
> > +/* Create a stream, to write to stdout or stderr, that uses
recode_write()
> > + to perform UTF-8 to console encoding translation. If STD_OUTPUT
is TRUE
> > + the returned svn_stream_t * writes to stdout, otherwise it writes
to
> > + stderr. */
> > +static svn_stream_t *
> > +recode_stream_create(svn_boolean_t std_output, apr_pool_t *pool)
> [...]
> > + stdout_stream = recode_stream_create(TRUE, pool);
> [...]
> > + stderr_stream = recode_stream_create(FALSE, pool);
>
> A point of style: for readability at the point of call, I'd prefer
passing
> "stdout" or "stderr" rather than "TRUE" or "FALSE" as the first
argument.
> Apart from that, this looks good.

Done, committed r19443. Closed issue #1997.

Paul B.

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 21 19:11:18 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.