Re: [PATCH] Fix Issue #1997

Paul Burba wrote:
> +/* Create a stream, to write to stdout or stderr, that uses recode_write()
> + to perform UTF-8 to console encoding translation. If STD_OUTPUT is TRUE
> + the returned svn_stream_t * writes to stdout, otherwise it writes to
> + stderr. */
> +static svn_stream_t *
> +recode_stream_create(svn_boolean_t std_output, apr_pool_t *pool)
[...]
> + stdout_stream = recode_stream_create(TRUE, pool);
[...]
> + stderr_stream = recode_stream_create(FALSE, pool);

A point of style: for readability at the point of call, I'd prefer passing
"stdout" or "stderr" rather than "TRUE" or "FALSE" as the first argument.
Apart from that, this looks good.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 20 22:17:06 2006