[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: typedef of svn_client_list_func_t

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-04-21 00:46:41 CEST

Hi,

In <87slo85aon.fsf@debian2.lan>
  "Re: typedef of svn_client_list_func_t" on Thu, 20 Apr 2006 20:06:16 +0100,
  Philip Martin <philip@codematters.co.uk> wrote:

> > > The typedef of svn_client_list_func_t is the following:
> > >
> > > typedef svn_error_t *(svn_client_list_func_t)(...);
> > > /\
> > >
> > > It seems that '*' is missed before 'svn_client_list_func_t':
> > >
> > > typedef svn_error_t *(*svn_client_list_func_t)(...);
> > > ^
>
> I think both are valid C and when used as a function parameter there
> is an automatic conversion from "function returning foo" to "pointer
> to function returning foo".

> I think this change is probably harmless in practice, but why does
> Kouhei Sutou need it? Is it a swig problem?

Yes. This is harmless in SWIG too. It's just a coding
problem. A typedef of other callback functions has '*'
but the typedef of svn_client_list_func_t doesn't have
'*'. This is strange look.

Peter, thanks for your change.

Regards,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 21 00:48:20 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.