Re: typedef of svn_client_list_func_t

"Peter N. Lundblad" <peter@famlundblad.se> writes:

> Kouhei Sutou writes:
> >
> > The typedef of svn_client_list_func_t is the following:
> >
> > typedef svn_error_t *(svn_client_list_func_t)(...);
> > /\
> >
> > It seems that '*' is missed before 'svn_client_list_func_t':
> >
> > typedef svn_error_t *(*svn_client_list_func_t)(...);
> > ^

I think both are valid C and when used as a function parameter there
is an automatic conversion from "function returning foo" to "pointer
to function returning foo".

> >
>
> I changed this in r19438.

Strictly speaking it's an ABI change and affects anyone writing code
like:

   svn_error_t *some_cb(...);
   svn_client_list_func_t *cb = some_cb;

I think this change is probably harmless in practice, but why does
Kouhei Sutou need it? Is it a swig problem?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org