Re: [PATCH] Flush stdout more often

Peter Samuelson <peter@p12n.org> writes:

>Ewwww. That's a much bigger kludge than his patch. Please don't tell
>me, as an end user, that I should have to wrap the svn client with a
>little script just to get output which it is reasonable to pipe through
>a pager.

It was suggested as a solution of his immediate problem. I assumed he
just wanted to get things done.

>You didn't read his patch, did you? He added 4 flush calls and removed
>one. That is not "littering flushes all over the code".

Of course I read his patch; please don't put words in my mouth.
The problem with that approach is that it is open-ended and requires
maintenance indefinitely after it has been applied.
Adding an option for setvbuf solves it once and for all.

>Can such an option be supported using less code than the 4 calls he
>added? That would, frankly, surprise me.

I claim it's not the absolute line count up-front that matters, but
how it will have to be maintained in the future.

>(Likewise for 'svn diff', though flushing at
>the end of each file might be worthwhile.)

Right, you already found a need for improvement. And then another
svn sub-command is added, which might need flushing. And so on.

Now look what you have done - you dragged me into a bicycle shed.
Shame on me for falling into the trap.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 10 12:33:43 2006