Re: [PATCH] Flush stdout more often

[Mattias Engdegård]
> What about the following trivial script:
>
> #!/usr/bin/env python
> import sys, os
> (pid, master) = os.forkpty()

Ewwww. That's a much bigger kludge than his patch. Please don't tell
me, as an end user, that I should have to wrap the svn client with a
little script just to get output which it is reasonable to pipe through
a pager.

Don't forget the Lesson of Arch: if you have to use shell
aliases/functions or custom command completion in order to have a
usable client, something about your CLI has gone very, very wrong.

> Instead of littering your flushes all over the code, just run your
> subversion command through this. No svn changes necessary.

You didn't read his patch, did you? He added 4 flush calls and removed
one. That is not "littering flushes all over the code".

> (If you insist in changing the client, why not add a global option
> which just sets the stdout buffering to line mode?)

Can such an option be supported using less code than the 4 calls he
added? That would, frankly, surprise me. I also like how his patch
doesn't touch areas like 'svn cat' and 'svn info' for which line
buffering is not needed. (Likewise for 'svn diff', though flushing at
the end of each file might be worthwhile.)