Re: svn commit: r19258 - in branches/svnserve-ssl/subversion: include libsvn_subr

On Sat, 2006-04-08 at 18:15 -0400, mark benedetto king wrote:
> I wish svn_stream were already extensible. It wasn't.

The stream type exists to provide a very specific set of polymorphic
operations, not to be a generic object interface.

> I don't see how to create some other functions which operate on the
> stream's baton, because I don't see how to get the stream to cough
> up its baton.

You control the code which creates the stream. Store the baton (or the
relevant part of the baton, if that's more convenient) somewhere.

> I really do think this is better than making a clone of the svn_stream
> implementation inside of libsvn_ra_svn, which is the next-easiest
> way that comes to mind.

Even if it turns out that cloning svn_stream in ra_svn is the most
convenient way of doing what I said above, that's still better than
pushing complexity into the deeper layers of the system. A system's
learning curve becomes steeper as complexity is pushed into the deeper
layers ("oh, we do this thing here because one of the fifteen callers
has this odd requirement...").

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 9 03:47:45 2006