Re: svn commit: r19278 - branches/svnserve-ssl/subversion/libsvn_subr

On Sun, Apr 09, 2006 at 01:22:53AM +0100, Max Bowsher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> mbk@tigris.org wrote:
> > Author: mbk
> > Date: Sat Apr 8 16:38:32 2006
> > New Revision: 19278
> >
> > Modified:
> > branches/svnserve-ssl/subversion/libsvn_subr/cmdline.c
> >
> > Log:
> > Initialize OpenSSL.
> >
> > * subversion/libsvn_subr/cmdline.c
> > (svn_cmdline_init): Add calls to OpenSSL's initializers.
>
>
> This isn't very nice. It means that things which don't involve network
> communication in any way - e.g. svnadmin, svndumpfilter, svnlook,
> svnversion - now have a dependency on OpenSSL.
>
> Couldn't OpenSSL be initialized in svn_ra_svn__init() and svnserve
> main() instead?
>

Yes. I've already moved it to a utility function living in libsvn_ra_svn
and called from exactly those two places.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 9 03:35:07 2006