[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19172 - trunk/subversion/libsvn_ra_serf

From: Greg Stein <gstein_at_lyra.org>
Date: 2006-04-05 04:38:33 CEST

On Tue, Apr 04, 2006 at 11:12:14AM -0700, jerenkrantz@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_ra_serf/property.c Tue Apr 4 11:12:14 2006
> @@ -26,6 +26,29 @@
> #include "ra_serf.h"
>
>
> +/* Our current parsing state we're in for the PROPFIND response. */
> +typedef enum {
> + NONE = 0,
> + RESPONSE,
> + PROP,
> + PROPVAL,
> +} prop_state_e;
>...
> @@ -210,29 +238,32 @@
> const char **attrs)
> {
> svn_ra_serf__propfind_context_t *ctx = userData;
> + prop_state_e state;
> + prop_info_t *info;
>
> - if (!ctx->in_response && strcmp(name.name, "response") == 0)
> + state = parser->state->current_state;
> +
> + if (!state && strcmp(name.name, "response") == 0)

state is an enumerated constant. You should compare against NONE
rather than zero.

>...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 5 08:25:39 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.