Re: [Svnmerge] [PATCH] ver2: remove progname hardcoding in svnmerge,py

Madan U S <madan@collab.net> wrote:

> [snip]
>> This will crash Windows users which run the program with
>> "/path/to/svnmerge" (no .py extension),
>
> am not sure why it will crash on windows. I tested this case (only
> 'svnmerge command') on linux, the split function takes care of this.

Ah sorry, you're right, I thinkoed split().
It doesn't handle the case where there are multiple dots in the filename
though. What about os.path.splitext?

>> Python is known for having incompatibilities problem with argv[0] across
>> platforms,
>
> aw! thats bad... but this is the first time am hearing about this...
google
> also doesnt return any results on this...

I meant to say that argv[0] is incompatible across platforms/shells (eg:
sometimes there is an absolute path, sometimes there is a relative path,
sometimes there is just the filename), and Python exposes this difference.
In effect, extracting only the basename should be fine.

So I take back the technical objections, but I still can't see why we would
need this.

-- 
Giovanni Bajo
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org