RE: [PATCH] ver2: remove progname hardcoding in svnmerge,py

On Friday 31 Mar 2006 7:00 pm, Malcolm Rowe wrote:
> On Fri, Mar 31, 2006 at 06:40:44PM +0530, Madan U S wrote:
> > [[[
> > Remove hard-coding of program name
>
> Why bother? We don't do this for any of the other executables.

Its good practise. Am guessing we dont do it for the *other* executables, because of the complexity, and the multiple source files which need this info (I mean, this data has to be passed on from the main to all other error handling functions).

But here, its just one single python script. It makes more sense to use argv than not to.

> Could you also try to send your patches with a Content-Type other than
> application/octet-stream, since that makes them harder to read than
> is necessary?

oops, sorry. Didnt realize the attachments were octet-stream.

Regards,
Madan.
Received on Fri Mar 31 15:41:21 2006