[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] show log message before changed paths in mailer.py

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-03-30 07:22:30 CEST

Julian Foad wrote:
> C. Michael Pilato wrote:
>
>> Julian Foad wrote:
>>
>>>>> + w('Author: %s\nDate: %s\nNew Revision: %s\n\nLog: %s\n\n'
>>>>> + % (data.author, data.date, data.rev, data.log))
>>>
>>> [...]
>>>
>>>>> - w('\nLog:\n%s\n' % data.log)
>>>
>>>
>>> ... it looks to me like it wrongly omits a newline after "Log:".
>>
>>
>> I'd call that a bugfix. A multi-line log message really should begin
>> on its
>> own dedicated line.
>
>
> Er... what? I'd call that the introduction of a bug, for the very same
> reason. Note that the lines added are shown first, and the lines
> deleted are shown afterwards.

Ahem. No, really, I *can* read diff format, I swear!

/me returns to his cave.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Thu Mar 30 07:27:02 2006

This is an archived mail posted to the Subversion Dev mailing list.