Re: Diff --old --new: too many peg revision specifiers

Julian Foad <julianfoad@btopenworld.com> writes:
> Excellent.
>
> The essential first patch to avoid proliferating this problem is to
> remove "-c" from the help message for this syntax, and preferably
> disallow it at the option-parsing stage (which is a bit clumsy, since
> extra logic is required in order to distinguish it from "-r"). The
> "-c" hasn't been released yet, so we just need to make sure this gets
> back-ported into 1.4.0 and there'll be no compatibility worries in
> that regard.
>
> Patch attached. OK so far?

Looks like a sensible step to me, & the patch looks good (I haven't
applied it, but reviewed it in-place).

Note that no backporting to 1.4.x is required, since it's just trunk.

> Next step: I think we shouldn't drop support for "-r" before v2, but I
> think it is OK for us to deprecate an aspect of the User Interface in
> a minor release just as we deprecate APIs. I propose to remove the
> mention of "-r" from the main description, and add a note stating it
> is accepted for backward compatibility, and describing its meaning.

+1

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org