Re: [PATCH]: Let users cancel out of command line client immediately if they signal 3 times

On Mon, 2006-03-13 at 19:43 -0500, Greg Hudson wrote:
> On Mon, 2006-03-13 at 08:58 -0500, Daniel Berlin wrote:
> > We can't make every expensive operation cancellable without needing
> > cleanup afterwards, and don't do so anyway. Commit will leave locks,
> > for example.
>
> It will?

Yup.

dberlin@linux:/mnt/gccstuff/gcc-clean/gcc> svn commit
svn: Caught signal
dberlin@linux:/mnt/gccstuff/gcc-clean/gcc> svn commit
svn: Working copy
'/mnt/gccstuff/gcc-clean/gcc/testsuite/gcc.c-torture/execute/builtins/lib' locked
svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for
details)
dberlin@linux:/mnt/gccstuff/gcc-clean/gcc>

> Why can't we clean up those locks?
>

We handle it like any other error that occurs during commit/whatever.
Anything else would require restructuring the wc code in very
significant ways, AFAIK.

Also, doing such cleaning up would itself takes a long time on a gcc
working copy, since it has a ton of directories. I imagine if we used
fcntl locking instead of lock files, we could just go away and the
kernel/libc would clean up after us.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 14 05:03:33 2006