[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Hostnames should be case-insensitive - tryiing to solve issue 2475 [+PATCH]

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-03-13 21:49:24 CET

Attached a new patch that addresses your questions. If you have any remarks,
please let me know.

> -----Original Message-----
> From: Branko ╚ibej [mailto:brane@xbc.nu]
> Sent: zondag 12 maart 2006 4:15
> Is there any reason not to use apr_uri_[un]parse to
> canonicalize the URL?

Not really, I thought I'd reinvent the wheel :) Fixed in this patch.

> > A consequence of solving the issue like this is that the URI in the
> > entries file should now be stored with a lowercase
> hostname.
> >
> It should be fairly easy to canonicalize the URLs while the
> entries file is being parsed. It's a memory-only operation,
> so performance is not an issue. I see no reason to bump the
> WC version because of such a change; after all, the WC format
> remains backward-compatible, and if we happen to rewrite the
> URL in the entries file (which we will, sooner or later),
> older clients can still use that working copy.
> -- Brane

I added code to convert the canonicalize the URL when read from the entries
file, to remain backwards compatible. I found it difficult to add an extra
test for this behaviour though. How is backwards compatibility for svn
tested anyway?

The patch is tested on windows + svn, http & local.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Mar 13 21:53:01 2006

This is an archived mail posted to the Subversion Dev mailing list.