[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Hostnames should be case-insensitive - tryiing to solve issue 2475 [+PATCH]

From: Branko Čibej <brane_at_xbc.nu>
Date: 2006-03-12 04:15:24 CET

Lieven Govaerts wrote:
> Branko,
>
> attached is a patch for this issue. The patch is implemented by converting
> the hostname to lowercase path.c/svn_path_canonicalize. This should make
> sure that all internal handling of URI's is done with a lowercase hostname.
>
> Is that what you suggested?
>
Yes, something like that.

Is there any reason not to use apr_uri_[un]parse to canonicalize the URL?

> A consequence of solving the issue like this is that the URI in the entries
> file should now be stored with a lowercase hostname. Working copies created
> with a pre-this-patch svn client with uppercase hostnames in their entries
> files are not supported anymore.
>
> I could add a temporary solution to automatically convert hostnames to
> lowercase in those entries. Other ( and better in my opinion ) option is to
> include this patch in a release that bumps the version of the entries file.
>
It should be fairly easy to canonicalize the URLs while the entries file
is being parsed. It's a memory-only operation, so performance is not an
issue. I see no reason to bump the WC version because of such a change;
after all, the WC format remains backward-compatible, and if we happen
to rewrite the URL in the entries file (which we will, sooner or later),
older clients can still use that working copy.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 12 04:15:41 2006

This is an archived mail posted to the Subversion Dev mailing list.