On 3/11/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> Ivan Zhakov writes:
> > On 3/10/06, Sebastian Tusk <sebastian.tusk@gmx.net> wrote:
> > >
> > > Most obvious problem is that test.svn-base gets hashed two times. Is the
> > > comparison (point 5) necessary?
> > Steps (2) and (3) can be ease merged with new stream translation API,
> > with change like this (don't look to code style, it is only for
> > testing!):
> ...
>
> Looks good, and even if it doesn't increase performance very much, I think
> it is good because it increases parallellization between client and server.
It should improve performance dramaticly when file larger system disk cache.
>
> > Also I mention there is additional checksum checking in case if not
> > fulltext deltas sent, which also can be avoided if move it before
> > editor->close_file() call. This mean that checksum will be checked
> > after transmission, but before closing file. I consider this is
> > acceptable.
> >
>
> Agreed. The important thing is that the transaction won't be
> committed in the end. The server might complain about corrupt
> svndiff, but only if the text-base is very corrupt (i.e. longer than
> it should be for exmple).
>
> Will you work on this?
Yes, I am going to commit these two changes in Monday. If you have
time, you can commit it of course. Might be better use owned streams
to close file automaticly.
--
Ivan Zhakov
Received on Sat Mar 11 01:09:04 2006