[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [DOCFIX] Fix ambiguous comments for svn_string_isempty()

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-03-10 14:34:04 CET

On Fri, Mar 10, 2006 at 06:16:58PM +0530, Madan U S wrote:
> > Perhaps it would make more sense to switch all the existing 'Return @c
> > TRUE' doc-comments to 'Return true ...' instead. If it bothers you,
> > anyway.
>
> no, the next function actually returns the svn defined bool value 'TRUE', not just an integer.
>

Um, so? That's an implementation detail, not a necessary part of the
interface. Since TRUE is always 'true' (that is, non-zero), the only
thing that the current contract allows you to do that that change would
make (technically, though not actually) incorrect would be something
like 'if (svn_string_compare(x, y) == TRUE)', which no-one is likely to
write anyway.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 10 14:35:54 2006

This is an archived mail posted to the Subversion Dev mailing list.