[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] [DOCFIX] Fix ambiguous comments for svn_string_isempty()

From: Madan U S <madan_at_collab.net>
Date: 2006-03-10 13:46:58 CET

> -----Original Message-----
> From: Malcolm Rowe [mailto:malcolm-svn-dev@farside.org.uk]
> Sent: Fri 3/10/2006 3:17 PM
> To: Madan U S
> Cc: dev@subversion.tigris.org
> Subject: Re: [PATCH] [DOCFIX] Fix ambiguous comments for svn_string_isempty()
>
> On Fri, Mar 10, 2006 at 11:01:46AM +0530, Madan U S wrote:
> > When I saw it first, and the next function comment said 'return @c TRUE' I was beginning to get confused.
>
> Perhaps it would make more sense to switch all the existing 'Return @c
> TRUE' doc-comments to 'Return true ...' instead. If it bothers you,
> anyway.

no, the next function actually returns the svn defined bool value 'TRUE', not just an integer.

Regards,
Madan.
Received on Fri Mar 10 13:49:50 2006

This is an archived mail posted to the Subversion Dev mailing list.