Re: [PATCH] Flush stdout more often

Branko ?ibej <brane@xbc.nu> wrote:

> Stefan Haller wrote:
> > My idea was to touch cmd-line client code only, no core code, so you
> > don't have to make any assumptions about ViewVC or others. Nothing will
> > change for them.
> >
> > You are right about diff, I missed that. However, as far as I can see
> > it is not necessary to touch libsvn_diff for that; it is sufficiant to
> > add fflush calls to libsvn_client/diff.c.
>
> This is inconsistent with the previous paragraph. libsvn_client is *not*
> specific to the command-line client; it is a core library that any
> client must use.

Ah, sorry, I didn't realize that.

OK, in that case I see two possibilities:

- add the flushing to libsvn_client/diff.c in the hope that it is the
appropriate thing for all clients, not just the svn command line client
(which I tend to think is true; at least I can't imagine that it would
hurt anybody); or

- live with the fact that diff output doesn't have the level of
streaminess that would be nice to have. Diff would then be no worse
than it is now, but all other subcommands would be improved; to me this
improvement would outweigh the inconsistency.

I could live with either.

-- 
Stefan Haller
Ableton
http://www.ableton.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org