Re: [PATCH] svn diff -r1:BASE URL asserts

Paul Burba wrote:
> Julian Foad <julianfoad@btopenworld.com> wrote on 01/12/2006 07:39:00 PM:
>
>
>>>>>>>diff -r1:BASE file:///home/BURBA/REPOS/SIG5
>>>>>>>Assertion failed: ! svn_path_is_url (path2), [...]
>>
>>Paul Burba wrote:
>>
>>>Anyway, here is my proposed fix. The "opt_state->start_revision.kind
>
> ==
>
>>>svn_opt_revision_base" isn't absolutely necessary since this case is
>>>caught in svn_client__get_revision_number(), but it seems more
>
> appropriate
>
>>>to check it here.
>>
>>My first reaction is: "What is special about BASE?" Why isn't
>>handled the same
>>as PREV and COMMITTED which are the other two revision keywords that
>>require a WC?
>
>
> Hi Julian,
>
> What's special about it is that svn diff x:BASE asserts and the other
> cases are handled, albeit inconsistently. My thought was just to prevent
> the assert - that's my rather lame excuse anyway since I *did* include the
> svn diff BASE:x case which the current code doesn't assert on. As you
> say, it does makes more sense to handle all these invalid diffs in a
> consistent manner...
>
>
>>It would be good to make BASE and PREV and COMMITTED all produce the
>
> same
>
>>error, preferably by all being handled at the same point. At
>>present, PREV and
>>COMMITTED produce:
>>
>>svn diff -r1:PREV file:///home/julianfoad/tmp/vcs/sandbox/trunk
>>svn: 'file:///home/julianfoad/tmp/vcs/sandbox' is not a working copy
>
> ...so to that end here is a new log and patch.

I have to apologize for letting this patch sit so long without being
addressed. Would any developer be able to review Paul's patch? If not,
I'll file an issue for in within a few days. Here is a link to Paul's
patch in the archive:

http://svn.haxx.se/dev/archive-2006-01/0350.shtml

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org