Re: [PATCH] Flush stdout more often

Justin Erenkrantz <justin@erenkrantz.com> wrote:

> Yes, I still object. I pointed out what my objections are to this
> patch and others have also outlined several strategies (custom
> notification callbacks or pty's) that can be undertaken by you to
> resolve your specific problem without cluttering Subversion's core
> code and to do so in such a way that will resolve this issue for prior
> releases too - which your patch can not do.

Others have pointed out that the patch is not only useful to my
particular problem, but also when you redirect output to a file and look
at it with tail -f, or pipe it through tee, things like that. You
assert that nobody cares about that, which I don't believe. Why should
this be less important for svn than it is for make or other tools that
produce line-based output?

As for my specific problem: to me, using a pty feels like much more the
wrong solution than having svn flush more often.

And a custom notification callback: maybe I don't understand well enough
what you are suggesting, so could you please briefly outline what you
think I should do in order to post-process the output of, say,
"svn merge". I want it to behave exactly like svn merge, with the same
option handling (including future enhancements); I don't see how I can
do that without completely reimplementing merge-cmd.c and notify.c in
python.

> > Does it help if I collect some timing data of some sort? If
> > so, what exactly would be useful?
>
> Any timing data that you could produce would not address my
> fundamental concerns that the core is the wrong place to address this.

I don't get it. You have heard several different reasons why the change
can be useful to some people; and you have heard that the change does no
harm (actually, makes no difference at all) for everybody else. Still
you object to it, "just because"?

-- 
Stefan Haller
Ableton
http://www.ableton.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org