[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18672 - trunk/subversion/libsvn_ra_serf

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2006-03-02 18:01:01 CET

On 3/1/06, Daniel Rall <dlr@collab.net> wrote:
> This code would be much more comprehensible if the "conn" fields
> include a prefix to differentiate between their types (e.g. "ra_conn"
> and "serf_conn", so all those "ctx->conn->conn" statements become
> "ctx->ra_conn->serf_conn").

Yah, I know that. =(

My hope is to abstract the ra_serf_connection_t and to make it an
opaque structure such that for except a small chunk of code (which
might not even live in ra_serf but in serf), nothing would even know
there's a a serf_connection_t called 'conn' inside of it.

My short-term goal for this week is to personally stop using neon and
ra_dav (hence SSL support and I'll be starting on authentication
today). Once I achieve that goal, I think I know of a bunch of places
to refactor the code even more. *sigh* -- justin

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 2 18:04:15 2006

This is an archived mail posted to the Subversion Dev mailing list.