Re: patch newline in log messages

Olleg Samoylov <olleg@mipt.ru> writes:
> I do not mungle log data. I show it as is. But if log data haven't
> trailing newline some bad things happens, output is jammed and count
> of lines =0. This is bad, so I increment count of lines and add
> newline to the end. This is all what doing my patch.

Here is what I am saying:

In Subversion today, it is possible (via the 'svn log' command) to
recover *exactly* the log message the committer entered. This is
because the addition of the extra newline is unconditional; if you
just strip that newline, you get the original log message. With your
patch, it is no longer possible to recover the exact log message,
because the output of 'svn log' will not reveal whether an extra
newline was added or not.

I'm not saying this is horrible; indeed, I'm advocating a solution
that has similar properties to your patch. However, there is no
denying that it would simply not be possible to recover the original
log data with your patch, because you can't know exactly where the
original data ends. (I'm talking about via the command line client
outpu -- obviously you could use direct APIs to get the log data).

When I say "munge the data", what I mean is "make the exact original
data unrecoverable". And what I said is true, but fortunately, the
kind of munging we're talking about does not harm the meaning of the
log message, so it may be permissible. It's still munging, however.

> > The server-side solution has the advantage of solving the problem for
> > all clients. I think I'd be +1 on your patch, as a compatibility
> > measure for older repositories, *if* we also implemented this behavior
> > on the server side. But doing only the client change seems wrong: log
> > messages are repository data, they should be in the correct format
> > when they are stored/retrieved in the repository.
>
> Well, but client may work with old servers thus client must be patched too.

Uh, right. That's what I said, in the text you quoted.

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org