Re: [PATCH] #9 OS400/EBCDIC Port: Running Hook Scripts

Paul Burba wrote:
> [[[
> OS400/EBCDIC Port:
>
> This is one of several patches to allow Subversion to run on IBM's
> OS400 V5R4. It provides a workaround of a limitation with
> apr_proc_wait() which always indicates a process exited
> successfully, regardless of whether it did or not.

Again, I have to ask, are you sure this is a known limitation and not a bug
that IBM could fix next week if told about it? This is a considerable chunk of
work-around code.

>
> * subversion\include\svn_io.h
> (svn_io_run_os400_cmd): New function declaration.

Can't you just use the API svn_io_run_cmd() and adjust its implementation?

Hmm, why aren't we using svn_io_run_cmd() already? Because it's inadequate?
Can we make it adequate?

> Index: subversion/libsvn_subr/io.c
> ===================================================================
[...]
> +#include <spawn.h> /* For spawn() and struct inheritance. */

Minor nit: comments that say why a header was included never get updated and so
are best omitted.

This isn't a review, just some initial comments. I might be able to look at it
tomorrow.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 28 03:22:46 2006