[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18315 - in trunk/subversion: include libsvn_client svn tests/cmdline

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-02-20 20:38:29 CET

On Sun, 5 Feb 2006, Julian Foad wrote:

> (Peter, these doc string problems may not be your fault, it's just that I've
> noticed them after this change.)
>

I fixed these in r18534. Feel free to improve further if you like.

>
> > * Attempt to create any parent directories for @a dst_path that do not exist.
>
> I added that line in r17415, but, by experiment, it does not appear to be true.
> I wonder whether it was true even then. I think it was true at least for WC
> destinations, before you added the following code to wc_to_wc_copy() and
> repos_to_wc_copy():
>
> > /* Make sure the destination parent is a directory and produce a clear
> > error message if it is not. */
> > SVN_ERR (svn_io_check_path (dst_parent, &dst_parent_kind, pool));
> > if (dst_parent_kind != svn_node_none)
> > return svn_error_createf (SVN_ERR_WC_NOT_DIRECTORY, NULL,
>
> What do we want? Do create parents, don't create parents, or compatibility
> with how it was before (which may have been a mixture)?
>
This code just improves the error message. If there is no parent, the
operation would fail when the code would try to open an adm access baton
to the dst parent. What we want? Someone seems to want an option to
create parents:-) See issue #1776.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 20 20:38:55 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.