[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18315 - in trunk/subversion: include libsvn_client svn tests/cmdline

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-02-05 18:35:20 CET

(Peter, these doc string problems may not be your fault, it's just that I've
noticed them after this change.)

 From svn_client.h: svn_client_copy3():
> /** Copy @a src_path to @a dst_path.
> *
> * @a src_path must be a file or directory under version control, or the
> * URL of a versioned item in the repository. If @a src_path is a
> * URL, @a src_revision is used to choose the revision from which to copy
> * the @a src_path.

... otherwise is src_revision ignored, or does it have some effect anyway?

> @a dst_path must be a file or directory under version
> * control, or a repository URL.

That's not right. dst_path must be a path or URL that is not yet under version
control. (It will become a file or directory, the same kind as src_path.)

> * If @a dst_path already exists, fail.

Now that you have written code that relies on particular error codes being
returned, we need to document them here.

> * Attempt to create any parent directories for @a dst_path that do not exist.

I added that line in r17415, but, by experiment, it does not appear to be true.
  I wonder whether it was true even then. I think it was true at least for WC
destinations, before you added the following code to wc_to_wc_copy() and
repos_to_wc_copy():

> /* Make sure the destination parent is a directory and produce a clear
> error message if it is not. */
> SVN_ERR (svn_io_check_path (dst_parent, &dst_parent_kind, pool));
> if (dst_parent_kind != svn_node_none)
> return svn_error_createf (SVN_ERR_WC_NOT_DIRECTORY, NULL,

What do we want? Do create parents, don't create parents, or compatibility
with how it was before (which may have been a mixture)?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 5 18:36:59 2006

This is an archived mail posted to the Subversion Dev mailing list.